-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the ability for a user to delete one/multiple profiles #9807
Comments
@benjthayer just a question here: in order to delete an account, I hope the user is required to enter password ;) Otherwise a user could easily delete some one else's account |
I thought about that too, but since you're already on thee person's computer, you could just delete the DB in the files, so I'm not sure doing a password validation helps. In a way, if I created an account, forget the password but I have the seed phrase, the only way for me to regen that account is to delete it first. |
Yeah, you're right... nvm then 😊 |
@benjthayer @caybro minor terminology correction - it's not an account, it's a profile!!! ;-) Accounts are things that live inside the Wallet, profiles are, well.... "User accounts"... But it's confusing if we use the word "account" for two things, so better if we call these "Profiles" and the only thing we call "Accounts" is the accounts that live inside the wallet. |
2 small adjustments made to the designs - updated the screenshots in the initial post above:
|
@jrainville do we support this yet? |
note: this a task for backend |
moved to 2.29 due to lack of space in this milestone |
@jrainville Is it there a backend task for supporting that? Or is it already implemented? |
As far as I know, mobile already has it implemented, so the status-go work exists. We just need to add the Nim backend, but that shouldn't be too hard as it's just function calls to call the API and a return/event when it's done |
Backend task added here: #15350 |
Currently there is no way for a user to delete one of their profiles.
After discussion with @John-44 we have created the following solution, enhancing the existing profile dropdown.
https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=26972-520493&t=LNBc5i9pzU8cJFDw-4
At the login screen, the profile selection dropdown contains a new item
Manage profiles
...Clicking this launches the
Manage profiles
dialog where the user can see all of their available profiles. The user can click Done or X at any time to dismiss...User chooses to delete profile
simon.eth
...When the user clicks the delete icon, a confirmation dialog is shown, clarifying the destructive outcome...
Once the user has confirmed, the confirmation dialog is dismissed and the
Manage accounts
list is updated with the deleted profile removed...When the user hits
Done
, theManage accounts
dialog is dismissed. Upon clicking the change profile dropdown again, they can see that the profile has also been deleted from that view...The list has a max height and becomes scrollable as shown...
cc @John-44 @jrainville @iurimatias
The text was updated successfully, but these errors were encountered: