Flaky test - TestRequestMultipleCommunities

[igor-sirotin]

I though that it's because of 1 * time.Second timeout, but increasing doesn't help.
Looks like the required envelope is fetched, but the community is not found after that for some reason.

So I suppose the flakiness actually shows a real bug here.

[igor-sirotin]

With #4509 applied, the test is only failing with

2023-12-22T20:10:32.860Z        DEBUG   bob-messenger   protocol/messenger.go:3788      Handled parsed message  {"site": "RetrieveAll", "hash": "0x06c180a8dc8d1cc7b49a3144219366f1aac8691eb26a63213979ef19caa690ad", "message-id": "0x6e72d49fdb2ec82d0a68064c87f0155cb85ea904a2a91361d55cf607a174748b"}
2023-12-22T20:10:32.860Z        DEBUG   bob-messenger.StoreNodeRequestManager   protocol/messenger_store_node_request_manager.go:409    community found {"requestID": {"requestType":0,"dataID":"0x025afe43844a605d7a497bbef6fe9b55510da030d04b253b71afa78f7e9df1b178"}, "envelopesCount": 1, "displayName": "EZcFuESbJf"}
2023-12-22T20:10:32.860Z        DEBUG   bob-messenger   protocol/messenger_mailserver.go:784    processBatch - all jobs complete        {"chatIDs": [], "fromString": "2023-11-21T20:10:33Z", "toString": "2023-12-22T20:10:33Z", "topic": ["0x84230b75"], "from": 1700597433, "to": 1703275833}
2023-12-22T20:10:32.860Z        DEBUG   bob-messenger   protocol/messenger_mailserver.go:721    processBatch cleanup - context done     {"chatIDs": [], "fromString": "2023-11-21T20:10:33Z", "toString": "2023-12-22T20:10:33Z", "topic": ["0x84230b75"], "from": 1700597433, "to": 1703275833}
2023-12-22T20:10:32.860Z        INFO    bob-messenger   protocol/messenger_mailserver.go:796    synced topic    {"chatIDs": [], "fromString": "2023-11-21T20:10:33Z", "toString": "2023-12-22T20:10:33Z", "topic": ["0x84230b75"], "from": 1700597433, "to": 1703275833}
2023-12-22T20:10:32.860Z        INFO    bob-messenger.StoreNodeRequestManager   protocol/messenger_store_node_request_manager.go:337    request finished        {"requestID": {"requestType":0,"dataID":"0x025afe43844a605d7a497bbef6fe9b55510da030d04b253b71afa78f7e9df1b178"}, "communityFound": true, "contactFound": false, "shardFound": false}
2023-12-22T20:10:32.860Z        DEBUG   bob-waku-node   common/filter.go:122    filters uninstall       {"id": "947ac5d8b210d9d4923b1dd022f25dd89fed755d0c66002fec9c4361d3e78be7"}
2023-12-22T20:10:32.860Z        DEBUG   bob-messenger   common/message_sender.go:1325   handling message segment        {"site": "handleSegmentationLayer", "hash": "0xc5edca4f501238086859bda0afc27971111f622398d1cd1f6ae018cab0071169", "EntireMessageHash": "0x7a7a071ed075db57910023eb1fd2a3f225396ccfe919a36914b55a54e62bbfe763e3ab26cfa51fc86c71b7f47675b73c1e21983d47ba718afccdda28d226eee401", "Index": 0, "SegmentsCount": 25}
2023-12-22T20:10:32.860Z        DEBUG   bob-messenger   common/message_sender.go:849    failed to handle segmentation layer message     {"site": "handleMessage", "hash": "\ufffd\ufffd\ufffdOP\u00128\u0008hY\ufffd\ufffd\ufffd\ufffdyq\u0011\u001fb#\ufffd\ufffd\ufffd\u001fj\ufffd\u0018ʰ\u0007\u0011i", "error": "NOT NULL constraint failed: message_segments.payload"}
2023-12-22T20:10:32.860Z        ERROR   bob-messenger   common/message_sender.go:919    failed to handle an encrypted message   {"site": "handleEncryptionLayer", "error": "failed to unmarshal ProtocolMessage: string field contains invalid UTF-8", "errorVerbose": "string field contains invalid UTF-8\nfailed to unmarshal ProtocolMessage\ngh.neting.cc/status-im/status-go/protocol/v1.(*StatusMessage).HandleEncryptionLayer\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/v1/status_message.go:126\ngh.neting.cc/status-im/status-go/protocol/common.(*MessageSender).handleEncryptionLayer\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/common/message_sender.go:910\ngh.neting.cc/status-im/status-go/protocol/common.(*MessageSender).handleMessage\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/common/message_sender.go:861\ngh.neting.cc/status-im/status-go/protocol/common.(*MessageSender).HandleMessages\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/common/message_sender.go:751\ngh.neting.cc/status-im/status-go/protocol.(*Messenger).handleRetrievedMessages\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/messenger.go:3698\ngh.neting.cc/status-im/status-go/protocol.(*Messenger).RetrieveAll\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/messenger.go:3252\ngh.neting.cc/status-im/status-go/protocol.(*Messenger).ProcessAllMessages\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/messenger.go:3273\ngh.neting.cc/status-im/status-go/protocol.(*storeNodeRequest).shouldFetchNextPage\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/messenger_store_node_request_manager.go:371\ngh.neting.cc/status-im/status-go/protocol.processMailserverBatch.func2\n\t/Users/igorsirotin/Repositories/Status/status-desktop-3/vendor/status-go/protocol/messenger_mailserver.go:755\nruntime.goexit\n\t/opt/homebrew/Cellar/go@1.19/1.19.13/libexec/src/runtime/asm_arm64.s:1172"}

Previously it was also failing without such log, just no community found in the fetched envelopes. Since this was prevented in with the mentioned above PR, now there's only one left.

[igor-sirotin]

Ok, on my #4509 branch I run the test 1851 times.
Didn't fail even once.

[igor-sirotin]

Fixed in #4509