feat_: implement PR review workflow #5877
Draft
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (38)
|
siddarthkay
force-pushed
the
pr-review-workflow-automation
branch
from
bfe0b66
to
8a90758
Compare
|
Looks like you have BREAKING CHANGES in your PR. Check-list
|
jakubgs
approved these changes
Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #5877 +/- ##
===========================================
+ Coverage 45.91% 46.06% +0.14%
===========================================
Files 888 888
Lines 157381 157379 -2
===========================================
+ Hits 72267 72495 +228
+ Misses 77010 76567 -443
- Partials 8104 8317 +213
Flags with carried forward coverage won't be shown. Click here to find out more. |
siddarthkay
force-pushed
the
pr-review-workflow-automation
branch
from
da41420
to
54ff2e6
Compare
|
|
||
| on: | ||
| pull_request_review: | ||
| types: [submitted] |
There was a problem hiding this comment.
We probably want all 3 event types:
Suggested change
| types: [submitted] | |
| types: | |
| - submitted | |
| - edited | |
| - dismissed |
| name: PR Review Workflow for Breaking Changes | ||
|
|
||
| on: | ||
| pull_request_review: |
There was a problem hiding this comment.
Just realised that we probably still need pull_request: [opened] here, otherwise the check won't appear until some review appear.
There was a problem hiding this comment.
Also, pull_request: [labeled, unlabeled] will also be needed to track breaking change add/removal.
|
Hmmm So it seems we will have to make the relevant teams inside status-go repository first. |
siddarthkay
force-pushed
the
pr-review-workflow-automation
branch
2 times, most recently
from
49a9364
to
0b606e4
Compare
siddarthkay
force-pushed
the
pr-review-workflow-automation
branch
from
0b606e4
to
6b552c1
Compare
|
@siddarthkay is it time to review this? Or are you still testing? |
siddarthkay
force-pushed
the
pr-review-workflow-automation
branch
2 times, most recently
from
1fb7f36
to
03dc775
Compare
siddarthkay
force-pushed
the
pr-review-workflow-automation
branch
from
03dc775
to
a3ef631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR Implements a PR review workflow like this :
breaking_changelabel exists on PR.@status-im/desktop-qaand@status-im/mobile-qaare asked for review on this PR.@status-im/desktop-qaand@status-im/mobile-qaapprove that PR the Github action will block the PR.