Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and respond to Status installed #24

Open
hesterbruikman opened this issue Feb 11, 2020 · 5 comments
Open

Detect and respond to Status installed #24

hesterbruikman opened this issue Feb 11, 2020 · 5 comments

Comments

@hesterbruikman
Copy link
Contributor

Problem

join.status.im/user/... can lower the effort of inviting people into and connecting on Status.
Currently the page is the same whether you have Status installed or not.

Current situation

  • When open join.status.im/user/... on a device that has Status is installed page does not suggest to open in Status
  • When scanning QR code on join.status.im/user/... with native or installed QR code reader on a device that has Status is installed, the QR code reader can only read the chat key, the url does not include any information to download or open Status

Expected situation

  • When open join.status.im/user/... on a device that has Status is installed shows prompt on page to open linked user profile in Status
  • When scanning QR code on join.status.im/user/... with native or installed QR code reader on a device that has Status is installed should open Status; Subsequently, if biometric unlock or Save password(-code) is enabled, linked user profile is opened in Status

Design for the prompt here: https://www.figma.com/file/TNCyHKtR3sx5EL6YznFWUa4O/Profile?node-id=4066%3A6653
72253029-e0583b00-3600-11ea-8b8a-b0e765cbf686

@hesterbruikman
Copy link
Contributor Author

@Ferossgp am I right that you implemented this for Android in the meantime?

Noticed that the button changes to Open in Status there, but not on iOS. Can you tell me what would be required to achieve this on iOS?

cc @andremedeiros

@andremedeiros
Copy link

Can you tell me what would be required to achieve this on iOS?

I'm not 100% confident that we can "detect" an app being installed on iOS, but we can try to launch it.

I'll check, but if we don't have a URL handler scheme, we should, specifically for these situations.

@hesterbruikman
Copy link
Contributor Author

I'll check, but if we don't have a URL handler scheme, we should, specifically for these situations.
I think we do: status-im/status-mobile#875 Not sure where to find it though and see what situations are included.

I believe @errorists anticipated this issue for iOS, hence the banner design to only add at the top of the page in case Status is installed. The button Download Status always remains the same in the design. Currently, the copy on the button changes to Open in Status when Status is installed, rather than showing the banner.

With "try and launch it", do you mean check and see what the app returns and update the page (show the banner) based on that?

@hesterbruikman
Copy link
Contributor Author

On iOS, currently the page shows 'Open in Status', if we cannot tell if Status is installed, the default should be Download Status with a link to the App store. Currently, the link is Open in Status which refreshes the page. This happens regardless of whether the app is installed, which is probably due to status-im/status-mobile#10083

@hesterbruikman
Copy link
Contributor Author

cc @xAlisher this open issue relates to the bug you found when going to https://join.status.im/u/0x04f1ab965a3db6433923ceba0488ff605f230aca4c4c93bb6563c10b700cfdbbed2a364c980b9cf9679f352584d4da44cc01fc1e7257f1d2b80ffff5af64aa129f

On iOS, we can't tell the difference between an app being installed or not. See comment above, the default should be to download, however, it seems we do attempt to open the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants