-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag v1.8 *requires* Laravel 5.8, not supports #30
Comments
Why do you want to install If you use |
Ah I see. Yes I did install 1.7. I think the issue is it's confusing that the README.md in 1.8 still says "Supports Laravel 5.5.29+" which is now incorrect for 1.8 and the master branch. Often people are going to manage their package versions manually and not just go by your own installation recommendation--my tolerance for automatic major/minor package updates may be different from your project's ideas about it. Generally what I see done to get around the problem of having a master branch README.md that still needs to work for old tags is to just spell it out: Laravel 5.5.29+, 5.6.*, 5.7.*composer require staudenmeir/eloquent-has-many-deep:"^1.7" Laravel 5.8.*composer require staudenmeir/eloquent-has-many-deep:"^1.8" Up to you, but just my 2 cents--it confused me. |
Since the package doesn't have its own website, the latest README represents the whole package and all of its versions. If people would visit the GitHub/Packagist page and only see "Supports Laravel 5.8", they wouldn't go looking for older versions that support Laravel 5.5–5.7 (I assume). I chose
Personally, I think that only very few manage this manually (at least for small add-ons like this). That's why I chose not to add a compatibility list (as long as there aren't new major versions with breaking changes). But I'll think about it. |
I've added a compatibility list to the README: |
Not sure if this is intentional, but since the README on 1.8 still says "supports laravel 5.5.29+", I'm guessing it's not.
I have laravel/framework locked to 5.5.* in my composer file (5.5 is LTS), and when attempting to install 1.8 I get a conflict due to the laravel requirements in your composer.json.
Output follows
The text was updated successfully, but these errors were encountered: