Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support eager-limit? #39

Closed
rick20 opened this issue Sep 5, 2019 · 6 comments
Closed

support eager-limit? #39

rick20 opened this issue Sep 5, 2019 · 6 comments

Comments

@rick20
Copy link

rick20 commented Sep 5, 2019

Hi, does hasOneDeep() supports HasEagerLimit ?
The docs said that it supports laravel's basic relationships HasOne/HasOneThrough/MorphOne but I'm using your hasOneDeep relationships.

Is it possible to use the window function from the hasOneDeep relationships?
Thank you

@rick20
Copy link
Author

rick20 commented Sep 5, 2019

I can't use hasOneThrough because it doesn't allow me to include pivot columns

@staudenmeir
Copy link
Owner

I'll look into it.

@staudenmeir
Copy link
Owner

What's your Laravel version?

@rick20
Copy link
Author

rick20 commented Sep 6, 2019

I'm using Laravel 5.8 but planned to migrate to 6

@staudenmeir
Copy link
Owner

staudenmeir commented Sep 17, 2019

I've released a new version that adds support for eager loading with limit.

You'll need to migrate to Laravel 6 first, it doesn't work with 5.8.

@rick20
Copy link
Author

rick20 commented Sep 28, 2019

Hi Jonas...apologize for late reply...been busy with our client's deployment this week
And thank you for the release...I'll look into it and will certainly use it in our upcoming project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants