-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/wrapf
#3055
Open
gururaj1512
wants to merge
12
commits into
stdlib-js:develop
Choose a base branch
from
gururaj1512:wrapf
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,479
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @gunjjoshi, could you review this PR? Some checks are failing, need guidance for it. |
gunjjoshi
reviewed
Nov 3, 2024
1 task
aayush0325
pushed a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
PR-URL: stdlib-js#3059 Ref: stdlib-js#2997 Ref: stdlib-js#3055 Ref: stdlib-js#649 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
/stdlib merge |
kgryte
added
Feature
Issue or pull request for adding a new feature.
Needs Review
A pull request which needs code review.
labels
Nov 18, 2024
gunjjoshi
requested changes
Nov 19, 2024
lib/node_modules/@stdlib/math/base/special/wrapf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/wrapf/test/test.native.js
Outdated
Show resolved
Hide resolved
@gururaj1512 Can you go through the CI failures and make necessary changes in this PR? There are some linting errors and test failures. |
1 task
gunjjoshi
added
Needs Changes
Pull request which needs changes before being merged.
and removed
Needs Review
A pull request which needs code review.
labels
Dec 9, 2024
/stdlib merge |
stdlib-bot
added
the
bot: In Progress
Pull request is currently awaiting automation.
label
Dec 16, 2024
stdlib-bot
removed
the
bot: In Progress
Pull request is currently awaiting automation.
label
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Issue or pull request for adding a new feature.
Math
Issue or pull request specific to math functionality.
Needs Changes
Pull request which needs changes before being merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a part of #649
Description
math/base/special/wrapf
, which would be the single-precision equivalent for math/base/special/wrap.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers