Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/wrapf #3055

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

gururaj1512
Copy link
Contributor

@gururaj1512 gururaj1512 commented Nov 2, 2024

Resolves a part of #649

Description

What is the purpose of this pull request?

float stdlib_base_wrapf( const float v, const float min, const float max );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 2, 2024
@gururaj1512
Copy link
Contributor Author

Hi @gunjjoshi, could you review this PR? Some checks are failing, need guidance for it.

@gunjjoshi gunjjoshi mentioned this pull request Nov 3, 2024
1 task
Planeshifter added a commit that referenced this pull request Nov 10, 2024
PR-URL: #3059
Ref: #2997
Ref: #3055
Ref: #649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
PR-URL: stdlib-js#3059
Ref: stdlib-js#2997
Ref: stdlib-js#3055
Ref: stdlib-js#649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Nov 18, 2024
@kgryte kgryte requested a review from gunjjoshi November 18, 2024 04:25
@gunjjoshi
Copy link
Member

@gururaj1512 Can you go through the CI failures and make necessary changes in this PR? There are some linting errors and test failures.

@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 9, 2024
@gururaj1512
Copy link
Contributor Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 16, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants