Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major bug: Windows names and colors are mixed up after browser restart #178

Closed
mastef opened this issue Nov 19, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@mastef
Copy link
Contributor

mastef commented Nov 19, 2021

This is one of the biggest bugs of the extension. The reason for this is that window names and colors are saved based on the "window id" that we receive from the browser.

But once we restart the browser, the reopened windows may have mixed up "window id" parameters. So a window that had id 7855 before, may now have id 3422. Or some windows may have gotten the id of a previous window.

This seems like a frustrating issue.

Possibility of fixing it:

Every 10 or 60 seconds, make a snapshot of the open windows that have a custom name/custom color and snapshot what tabs they currently have saved.
Also try this on a browser close event, if possible.

Once a browser is re-opened, and somehow fully loaded ( Can we time this? Is there an event when a browser restoration is complete? ), or if a window is restored from history ( e.g. "re-open 7 closed tabs" ) - then compare against the saved list if it matches any of the windows we had saved, and restore the color/name to it.

This is a very funky logic, which is why this bug has been so prevalent.

Also how long should we remember a window name/color? What if a second window is opened with the same tabs... which window are we monitoring then for changes?

@uday-arrcus
Copy link

What is the plan to fix/resolve this issue?

@mastef
Copy link
Contributor Author

mastef commented Oct 1, 2024

Possibly fixed in 6.0.0

@uday-arrcus
Copy link

uday-arrcus commented Oct 1, 2024

Names are retained but the names are not retained with the actual windows/groups.

@mastef
Copy link
Contributor Author

mastef commented Oct 2, 2024

Names are retained but the names are not retained with the actual windows/groups.

Waiting for 6.0.0 to be approved, as it's not live on the Chrome Web Store yet. You can download it directly from the releases page until then.

@uday-arrcus
Copy link

uday-arrcus commented Oct 6, 2024

Thanks for the update, i use this extension in Firefox. Hope the latest version resolves the issue in Firefox as well. Could you point to the releases page from where i can download directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants