[BUGFIX] error when trailing slash present in argument to generator #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @param {String} entityName | ||
| @return {null} | ||
| */ | ||
| Blueprint.prototype.normalizeEntityName = function(ui, entityName) { |
There was a problem hiding this comment.
I believe that ui is not needed, it is set as a prop on the blueprint instance when instantiated, so even if a downstream blueprint wanted it, it would just use this.ui.
There was a problem hiding this comment.
Also, as is, the params listed in the docs are incorrect.
There was a problem hiding this comment.
Absolutely. I added the ui param before I realized that there is a catch that prints errors through ui in red. Fixed!
Good catch! :)
|
LGTM |
|
This is awesome. Great work! |
rwjblue
added a commit
that referenced
this pull request
Jun 28, 2014
…error [BUGFIX] error when trailing slash present in argument to generator
|
Awesome, thanks! |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a hook inside the Blueprint install function that by default throws and error when there is a trailing slash in the argument to
ember generate. This can be overridden within each individual blueprint by overriding the normalizeEntityName function inside the constructor for that blueprint.Let me know what you think.
resolves #1164