Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chain from express server #1474

Merged
merged 1 commit into from
Jul 24, 2014
Merged

Remove chain from express server #1474

merged 1 commit into from
Jul 24, 2014

Conversation

bcardarella
Copy link
Contributor

It is no longer necessary

It is no longer necessary
@rwjblue
Copy link
Member

rwjblue commented Jul 24, 2014

Can you confirm this is the only usage, and then remove from package.json also?

@bcardarella
Copy link
Contributor Author

@rwjblue it is not, the serve-files middleware uses chain. I'm not quite sure what the intent of @MajorBreakfast's code is there so I left it in

stefanpenner added a commit that referenced this pull request Jul 24, 2014
…s-server

Remove chain from express server
@stefanpenner stefanpenner merged commit 0e357a0 into ember-cli:master Jul 24, 2014
@bcardarella bcardarella deleted the bc-remove-chain-from-express-server branch July 24, 2014 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants