Allow calling this._super in subclasses of CoreObject.

[rwjblue]

• Add a few tests for CoreObject.
• Allow calling methods on your parent class via this._super.someMethod().

Illustration:

var fooCalled, barCalled, instance;

var Klass1 = CoreObject.extend({
  foo: function() {
    fooCalled = true;
  }
});

var Klass2 = Klass1.extend({
  foo: function() {
    this._super.foo();
  },

  bar: function() {
    barCalled = true;
    this._super.foo();
  }
});

instance = new Klass2();
instance.bar();

assert(fooCalled, 'foo called');
assert(barCalled, 'bar called');

fooCalled = false;
instance.foo();

assert(fooCalled, 'foo called');

[dgeb]

@rwjblue This is nice and lightweight and gets the job done. 👍

Let me know if you're interested in a solution that allows calls to this._super() from within methods to call the corresponding method on the superclass, without needing to call this.super.foo(). Obviously, my suggestion is more involved, but may be more familiar to Ember devs.

[rwjblue]

Updated to include a super wrapper (basically the same implementation as Ember), with a few tweaks.

I attempted to make this conceptually similar to ES6 classes super (see here).

[bcardarella]

@rwjblue failed

[rwjblue]

I'm not exactly sure what the deal here is. It is only failing under node 0.11...

[rwjblue]

Tracked down the issue in node 0.11:

Apparently, setting name on a function is not allowed (see here). Fixed with a simple check to ensure we don't override native function properties or methods in the super wrapper.

[rwjblue]

Updated to ensure we do not wrap methods that do not call _super.

[stefanpenner]

I really dislike ember's super, can we just do it manually like:

this._super$foo(..)

https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/map.js#L350
https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/map.js#L363

its ugly but "just works"

[rwjblue]

My initial implementation actually, just made _super the super class's prototype. This allowed for this._super.foo() (which is sorta close to the ES6 way).

Will revert to that implementation (which was really just a single line change IIRC).

[rwjblue]

Moved back to super simple _super. Will merge when green...