Provide useful error message when styles/app.[ext] is not found #1866
Conversation
jmonster
changed the title
To avoid future developer confusion as witnessed on issue ember-cli#1641
jmonster
force-pushed
the
warn-missing-style
branch
from
57991bd
to
69360ae
Compare
|
|
||
| if (!ext) { | ||
| var attemptedExtensions = Array.isArray(this.ext) ? this.ext : [this.ext]; | ||
| throw new Error('app/styles/app.[' + attemptedExtensions.join('/') + '] does not exist'); |
There was a problem hiding this comment.
Can you throw a SilentError instead?
There was a problem hiding this comment.
running tests locally now
There was a problem hiding this comment.
Absolutely just time constraints, I'll try to get to it this evening. On Fri, Sep 5, 2014 at 1:20 PM, stefanpenner/ember-cli reply@reply.github.com wrote: In lib/preprocessors/style-plugin.js:
@@ -15,7 +15,14 @@ StylePlugin.prototype.constructor = StylePlugin;
StylePlugin.prototype._superConstructor = Plugin;StylePlugin.prototype.toTree = function(tree, inputPath, outputPath, options) {
- var input = path.join(inputPath, 'app.' + this.getExt(inputPath, 'app'));
- var ext = this.getExt(inputPath, 'app');
- if (!ext) {
- var attemptedExtensions = Array.isArray(this.ext) ? this.ext : [this.ext];
- throw new Error('app/styles/app.[' + attemptedExtensions.join('/') + '] does not exist');
@jmonster - Ping?
—Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
No worries, we updated in another commit/pr and merged. Thank you!!
|
superseded by: #1894 |
To avoid future developer confusion as witnessed on issue #1641. This PR provides improved error messaging to assist developers in debugging their applications; it does not fix any actual bugs [since the problem is not really a bug].