Addon configuration. #1972
Merged
Addon configuration. #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements: ember-cli#1907 A new `config` hook is available for addons. It can be used to alternate application configuration (example: toggling FEATURE flags for Ember) or to read the current config and change addon behaviour (example: importing dependencies conditionally). Interface: ``` // environment - 'development', 'test', 'production' // currentConfig - hash with config for given environment config: function(environment, currentConfig) {} ```
|
There will be more PR's incoming, but this gets us moving in the correct direction (and lands addon configuration merging). |
| @@ -182,6 +183,10 @@ EmberApp.prototype._notifyAddonIncluded = function() { | |||
| }, this); | |||
| }; | |||
|
|
|||
| EmberApp.prototype.configureAddons = function() { | |||
| // do something that will make addon `config` hook to fire | |||
There was a problem hiding this comment.
For me that's the important part but not sure how to make it happen.
There was a problem hiding this comment.
Just to confirm, you want the configuration to be available within the included hook, right?
There was a problem hiding this comment.
So that you can tailor what is included based on the full addon + app config.
There was a problem hiding this comment.
Refactored this to Project.prototype.config (and removed this configureAddons function). If you need the configuration in an addon's included hook, call this.project.config(this.app.env).
rwjblue
force-pushed
the
addon-config
branch
3 times, most recently
from
f9a2455
to
bc8c749
Compare
rwjblue
force-pushed
the
addon-config
branch
from
bc8c749
to
b0c240a
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confighook for addons #1914.updateCachemethod.Project.prototype.configPath.Project.prototype.getAddonConfig.Project.prototype.configto merge addon config with application config.