Ensure all addon hooks are executed in addon test harness. #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when using the `tests/dummy/` app in an addon project, the only hooks that were called were build related (because we only added the addon project to the `addons` list in the `Brocfile.js`). Now, we always add the addon project. This allows testing commands, blueprints, middleware hooks, etc.
rwjblue
force-pushed
the
addon-hooks-in-addon-project-dummy
branch
from
1025f63
to
40c143e
Compare
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Oct 5, 2014
Ensure all addon hooks are executed in addon test harness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using the
tests/dummy/app in an addon project, the only hooks that were called were build related (because we only added the addon project to theaddonslist in theBrocfile.js).Now, we always add the addon project. This allows testing commands, blueprints, middleware hooks, etc.
Closes #2188.