-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure line + col information is also displayed #2246
Conversation
stefanpenner
commented
Oct 7, 2014
- tests
- acceptance tests passing again. (about 9 simple output related acceptance tests are failing)
- i think we should extract the error logging logic, share it and test it in 1 place.
LGTM - Real smoke tests will be annoying, but possible. We can merge this and add an issue to create smoke tests for build failures during |
9ddaf59
to
06d2e35
Compare
@@ -110,6 +110,15 @@ describe('livereload-server', function() { | |||
assert.equal(trackCount, 1); | |||
}); | |||
|
|||
function BuildError(input){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in lib/errors/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/fixtures/errors ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we can share this between the build task aswell
i need to head out to work, will try and finish this up as soon as i get there. |
06d2e35
to
d224a81
Compare
d224a81
to
58c7d69
Compare
@rwjblue many tests and refactorings. |
👍 |
ensure line + col information is also displayed