Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitignore in app blueprint #2285

Merged
merged 1 commit into from
Oct 10, 2014
Merged

Conversation

xymbol
Copy link

@xymbol xymbol commented Oct 10, 2014

The line for bower_components should not end in /* or, the pattern matches files underneath bower_components but not the bower_components directory itself. This breaks git-clean and, contradicts the pattern for node_modules, which is correct. See: http://git-scm.com/docs/gitignore.

Directory patterns should not end in `\*`.
stefanpenner added a commit that referenced this pull request Oct 10, 2014
Fix gitignore in app blueprint
@stefanpenner stefanpenner merged commit 3a37389 into ember-cli:master Oct 10, 2014
@xymbol xymbol deleted the fix-gitignore branch December 4, 2014 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants