Prevent an app name of test.
#256
Conversation
| var isEmberCliProject = require('../utilities/is-ember-cli-project'); | ||
| var checkName = require('../utilities/name-check'); |
There was a problem hiding this comment.
why name the local var the reverse of the filename (checkName vs name-check.js)?
There was a problem hiding this comment.
no specific reason tbh, I can rename it.
|
👍 - I like this (thank you for picking it up).
|
|
Do we really want to introduce this spaces code style? I'd rather have multi var declarations instead of all these spaces. If we add it though, then we should follow it everywhere and I'll add it to the style guide (ARCHITECTURE.md) in my other PR. |
Related to #232, initial PR by @rjackson. + prevents the application to be named `test` + introduces new helpers `stubPath` and `stubBlueprint` + refacators `generate` test + adds tests for `init` and `new` commands + changes `npm test` command to make sure we run `unit/commands` tests + adds an entry to CHANGELOG
|
@rjackson your point is well taken and sorry that PR got a little messy. Whitespace changes are not directly related, agreed. @MajorBreakfast we should definitely agree on code style. It's kinda of bad to enforce my code style preference onto the project. Let's get the docs out of the door this weekend and we document and agree on coding style. |
|
@MajorBreakfast I'm a sucker for 1 var for line + OCD alignment. |
Prevent an app name of `test`.
|
@stefanpenner Okay then, let's do it xD |
Related to #232, initial PR by @rjackson.
teststubPathandstubBlueprintgeneratetestinitandnewcommandsnpm testcommand to make sure we rununit/commandstests