Set locationType to none in tests #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests should not affect the url so router location should be none - Testem requires a base URL
teddyzeenny
force-pushed
the
test-location
branch
from
d7730da
to
af5a8fd
Compare
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Nov 30, 2014
Set locationType to none in tests
rwjblue
added a commit
that referenced
this pull request
Nov 30, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2559
nonePreviously we were setting location to
autoin test environment so that we get a<base>tag during build (which testem needs), and then setting it back tononein thestartApphelper before running the tests. But that last step was removed, which caused the tests to run with locationauto, which breaks reloads.It might be a bit confusing to set
locationType:'auto'inenvironment.jsjust to get a<base>tag, when actually the tests would run withlocationType: 'none'. So I just set location tononeand added a<base>tag anyway.@rwjblue is it safe to set a
<base>tag in locationnoneor was de7c6bc fixing a previous issue?