-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull server files from http-{mock,proxy} into their own blueprint #2610
Pull server files from http-{mock,proxy} into their own blueprint #2610
Conversation
Pull server files from http-{mock,proxy} into their own blueprint
thank you sir! |
This seems to have caused conflicting blueprints for |
@indirect - Yes, I believe that it should. Can you open an issue (or PR)? |
@indirect that's odd because that's exactly what the https://github.com/stefanpenner/ember-cli/blob/master/blueprints/http-proxy/index.js#L26 I'll check to see what I missed. |
I can try to get you a diff tomorrow, if that would help. The changes I noticed were whether morgan was included in server/index.js, and whether connect-restreamer was used before the proxies were used.
|
@indirect - Are you using the built-in generators or overridden generators from another addon (like ember-cli-coffeescript)? |
Ohhhhh, wow, I feel dumb. After checking, yes, I have an overwritten generator for http-proxy and no overwritten generator for server. Thanks, and sorry about that! |
@indirect no problem, this project moves fast. Hopefully we can figure out a way of messaging these issues. Maybe some improved debug logging in this area? |
@stefanpenner @indirect improved logging definitely. Console output along this lines of:
would it make it much clearer what’s afoot here. |
Fixes #2356