Use AST transforms for adding new routes and resources + path option #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
force-pushed
the
apply-ast-transforms-to-router
branch
from
7cd03ac
to
8eddc20
Compare
This uses the following micro lib https://github.com/abuiles/ember-router-generator, we still need support for deletions. A full list of scenarios can be seen in the following test file https://github.com/abuiles/ember-router-generator/blob/master/tests/generator-test.js
abuiles
force-pushed
the
apply-ast-transforms-to-router
branch
from
8eddc20
to
690b164
Compare
+1, this is the right tool for the job. |
|
I suspect the appveyor failure is unrelated, so this seems good to go. Someone will need to fix those failures soon, maybe i'll have time tonight. |
stefanpenner
added a commit
that referenced
this pull request
Dec 15, 2014
Use AST transforms for adding new routes and resources + path option
This was referenced Dec 15, 2014
|
<3 |
abuiles
added a commit
that referenced
this pull request
Dec 15, 2014
|
👍 |
|
Can't wait until this is released, a real pain to manually fix the map each time |
This was referenced Jan 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the following micro lib
https://github.com/abuiles/ember-router-generator, we still need
support for deletions.
A full list of scenarios can be seen in the following test file
https://github.com/abuiles/ember-router-generator/blob/master/tests/generator-test.js
Instead of using esprima + escodegen I went with https://github.com/benjamn/recast which seems more estable and offers a nicer support for printing code, also works the ES6 features we are using.
I also added the path option so we can now do
ember g route friends/edit --path=:friend_id/editorember g route account --path=my/accountThe following gif shows the new generator in action:
refs: #2729 closes #2724