Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where app.js files are appended to tests.js #347

Merged
merged 1 commit into from
Apr 13, 2014
Merged

Fix issue where app.js files are appended to tests.js #347

merged 1 commit into from
Apr 13, 2014

Conversation

machty
Copy link
Contributor

@machty machty commented Apr 13, 2014

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Apr 13, 2014

👍

This was causing Ember and Ember Data to be loaded in the tests.js file (even though it should not have been), which meant that they were loaded twice (once from app.js and again in tests.js).

@twokul
Copy link
Contributor

twokul commented Apr 13, 2014

make sure to add an entry to CHANGELOG

stefanpenner added a commit that referenced this pull request Apr 13, 2014
@stefanpenner
Merge pull request #347 from machty/legacy-test-files
0480164 
Fix issue where app.js files are appended to tests.js
@stefanpenner stefanpenner merged commit 0480164 into ember-cli:master Apr 13, 2014
stefanpenner added a commit that referenced this pull request Apr 13, 2014
@stefanpenner
update read me for #347
0e25bf0
homu added a commit that referenced this pull request Jul 29, 2016
@homu
Auto merge of #6126 - ember-cli:greenkeeper-supertest-2.0.0, r=nathan…
32fa7f5 
…hammond

Update supertest to version 2.0.0 🚀

Hello lovely humans,

[supertest](https://www.npmjs.com/package/supertest) just published its new version 2.0.0.

<table>
  <tr>
    <th align=left>
      State
    </th>
    <td>
      Update 🚀
    </td>
  </tr>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      supertest
    </td>
  </tr>
  <tr>
    <th align=left>
      New version
    </td>
    <td>
      2.0.0
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      devDependency
    </td>
  </tr>
</table>

This version is **not covered** by your **current version range**.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of supertest.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and while I’m just a bot, there is a group of people who are happy to teach me new things. [Let them know](https://github.com/greenkeeperio/greenkeeper/issues/new).

Good luck with your project ✨

You rock!

🌴

---
[GitHub Release](https://github.com/visionmedia/supertest/releases/tag/v2.0.0)

<p>PR-347 - Update to superagent ^2.0.0 (thanks <a href="https://urls.greenkeeper.io/saintedlama" class="user-mention">@saintedlama</a>)</p>

---
The new version differs by 12 commits .

- [`054ad57`](ladjs/supertest@054ad57) <code>Prepare for 2.0.0 release.</code>
- [`7ca0574`](ladjs/supertest@7ca0574) <code>Upgrade superagent to 2.x (#347)</code>
- [`7d35f22`](ladjs/supertest@7d35f22) <code>Change 'super-agent' to 'superagent' in Readme. (#343)</code>
- [`d0c1457`](ladjs/supertest@d0c1457) <code>Fix eslint checks .pem (#331)</code>
- [`076ce21`](ladjs/supertest@076ce21) <code>Fix typo on line 74 (#330)</code>
- [`a920af5`](ladjs/supertest@a920af5) <code>MISC Update dev deps, small updates to README.</code>
- [`25665c0`](ladjs/supertest@25665c0) <code>Fix readme for .expect(fn), fixes #253 (#262)</code>
- [`480b9bb`](ladjs/supertest@480b9bb) <code>Merge pull request #324 from visionmedia/eslint-refactor</code>
- [`af3c013`](ladjs/supertest@af3c013) <code>Slight cleanup to esline rules. Remove some overrides, refactor logic in _assertHeader function.</code>
- [`1849094`](ladjs/supertest@1849094) <code>Refactor source code to use eslint with airbnb legacy rules.</code>
- [`ecced93`](ladjs/supertest@ecced93) <code>Merge pull request #318 from oskarcieslik/patch-1</code>
- [`a1533e5`](ladjs/supertest@a1533e5) <code>Changed example with cookie-parser</code>

See the [full diff](ladjs/supertest@f4efb75...054ad57).

---
This pull request was created by [greenkeeper.io](https://greenkeeper.io/).

<sub>Tired of seeing this sponsor message? ⚡ `greenkeeper upgrade`</sub>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@machty @rwjblue @twokul @stefanpenner