Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after server and build commands. #444

Merged
merged 1 commit into from
Apr 25, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 25, 2014

We are currently not cleanuing up our tmp/ directories after build and server are completed. This led to a 15 minute rm -rf tmp/ session for me...

Screenshot of current behavior:

screenshot

Screenshot showing new behavior:

Screenshot

@twokul
Copy link
Contributor

twokul commented Apr 25, 2014

LGTM, add an entry to the CHANGELOG please.

Ensure that `tmp/` is cleaned up when the command is finished.

@danmcclain / @rjackson
@stefanpenner
Copy link
Contributor

so if we have the server running, and you run "build" you will blow away your temp files "server" needs resulting in explosions. I absolutely agree this is a problem, but I am unsure about the solution for now.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 25, 2014

Each builder is only cleaning up trees that IT created. They should not conflict.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 25, 2014

@twokul - Added CHANGELOG entry.

@stefanpenner
Copy link
Contributor

@rjackson ah, didn't catch that, perfect!

stefanpenner added a commit that referenced this pull request Apr 25, 2014
Cleanup after `server` and `build` commands.
@stefanpenner stefanpenner merged commit 2ccc6e9 into ember-cli:master Apr 25, 2014
@alpacaaa
Copy link

Is this still in master? My tmp directory is defnitely overweight.

@rwjblue
Copy link
Member Author

rwjblue commented Jun 27, 2014

Please provide detailed steps on reproducing. I've been trying to track down the remaining scenarios that still are not cleaning up after themselves.

We have regression tests to confirm tmp/ is cleaned after ember server and ember test --server. And I have just confirmed that ember build cleans up after itself properly.

@alpacaaa
Copy link

So I made a quick test and I noticed that it happens when I quit the terminal without shutting down the server. If I CTRL + C, the folder is cleaned up correctly. If I ⌘ + Q, the folder is still full and it reaches a few GBs in size very quickly.

Thanks

@rwjblue rwjblue deleted the pruning branch June 29, 2014 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants