-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Leek #448
Integrate Leek #448
Conversation
@@ -47,7 +49,15 @@ function Command(options) { | |||
throw new Error('Command "' + this.name + '" has no run() defined.'); | |||
} | |||
|
|||
this.run = options.run; | |||
this.run = function(ui, environment) { | |||
if (environment && environment.cliArgs && self.leek) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when are we missing leak?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant check, will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would only be concerned that it masks actual errors.
thanks bro!! |
#350