Use the current package.json name value for ember init.
#491
Conversation
| @@ -18,7 +18,8 @@ module.exports = new Command({ | |||
|
|
|||
| run: function(environment, options) { | |||
| var cwd = process.cwd(); | |||
| var rawName = path.basename(cwd); | |||
| var pkg = require(cwd + '/package'); | |||
There was a problem hiding this comment.
this will fail if no package is present? seems incorrect
|
Just updated to use |
|
Now with tests. |
|
can you just put project in the outer environment object: https://github.com/stefanpenner/ember-cli/blob/master/lib/cli/index.js#L37 and inject it here: https://github.com/stefanpenner/ember-cli/blob/master/lib/cli/cli.js#L26 on commands? This may seem a bit strange, but it keeps knowledge of how to get the project instance isolated from commands, which is more aligned with the command refactor. |
| @@ -9,7 +9,7 @@ module.exports = new Task({ | |||
| // Options: Boolean dryRun | |||
| run: function(ui, options) { | |||
| var cwd = process.cwd(); | |||
| var rawName = path.basename(cwd); | |||
| var rawName = options.rawName || path.basename(cwd); | |||
There was a problem hiding this comment.
seems like we never want to fallback to path.basename instead always requiring the correct inputs
There was a problem hiding this comment.
Just refactored as you suggested earlier. I've still got a couple failures I'm working through though.
There was a problem hiding this comment.
ah ok, thanks! Just reviewing before i got to sleep
There was a problem hiding this comment.
this still seems strange
Refactor `CLI` to inject the current Project into each command.
|
Updated with latest round of formatting tweaks. Please let me know if there is anything else needed. |
|
looks good |
Use the current package.json name value for `ember init`.
Closes #395.
Please note I did not add tests for this, as this code path is completely refactored (and tested) in #466.