Check pkg before trying to read name.

[abuiles]

When trying to start a new project on a empty dir, init will fail, the reason is that project is a NULL_PROJECT which doesn't have pkg https://github.com/stefanpenner/ember-cli/blob/3e9323266e4b0922d8e519a1ac5444d796c2c98a/lib/models/project.js#L30

Steps to reproduce

mkdir /tmp/foo
cd /tmp/foo
ember init

[abuiles]

@rjackson ^^

[abuiles]

I might add some tests for this tomorrow.

[stefanpenner]

should the NULL_PACKAGE of an empty pkg? That would likely be correct and follow this pattern

[rwjblue]

I think that we should be checking Project.prototype.name instead of Project.prototype.pkg.name, and our NULL_PROJECT can simply return undefined (which is what it is).

[MajorBreakfast]

should be environment.project.isEmberCLIProject()

[stefanpenner]

good point

[abuiles]

@MajorBreakfast @stefanpenner this is not always true, at least not when running new, I went with that first and the command was breaking. I'll dig again later today.

[rwjblue]

Correct, when running new, we are operating on the NULL_PROJECT which returns false for isEmberCLIProject(). As I mentioned below (in the normal comments) we should just ask the project for its name.

If NULL_PROJECT.prototype.name returned undefined, then all you would need is this (or a ternary if you prefered (which I do not)):

var packageName      = environment.project.name();

if (!packageName) {
  packageName = path.basename(process.cwd());
}

[abuiles]

@rjackson cool, I'll go with that.

[MajorBreakfast]

Hmm let's not introduce too many helper methods on Project.

It's just as short without project.name():

var packageName = path.basename(process.cwd());

if (environment.project.isEmberCLIProject()) {
  packageName = environment.project.pkg.name;
}

[stefanpenner]

please ensure we have some coverage for this.

[abuiles]

@rjackson I won't be able to look at this at least for the next 5-6 hours :( and people keep complaining about, if you want to give it a go, feel free to. cc @stefanpenner @MajorBreakfast

[twokul]

closing in favour of #546, thanks @abuiles