Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow concurrent ember test --server and ember server. #862

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 30, 2014

Prior to this, both ember server and ember test --server attempted to write to (and clear) tmp/output. This allows the test task to use a custom randomly named temp dir instead (which prevents the collision).

@rwjblue
Copy link
Member Author

rwjblue commented May 30, 2014

Rebased to use new model structure for Builder and Watcher.

@rwjblue
Copy link
Member Author

rwjblue commented May 30, 2014

Also, fixes ember test --server (which is broken after the recent refactor to models for watcher/builder).

@stefanpenner
Copy link
Contributor

@rjackson LGTM, merge when green

Prior to this, both `ember server` and `ember test --server` attempted
to write to (and clear) `tmp/output`. This allows the test task to use a
custom randomly named temp dir instead (which prevents the collision).
rwjblue added a commit that referenced this pull request May 30, 2014
…-for-testem

Allow concurrent `ember test --server` and `ember server`.
@rwjblue rwjblue merged commit 933d7dd into ember-cli:master May 30, 2014
@rwjblue rwjblue deleted the ensure-random-directory-is-used-for-testem branch May 30, 2014 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants