Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clobber window.ENV. #922

Merged
merged 1 commit into from
Jun 6, 2014
Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 6, 2014

No description provided.

@@ -1 +1,2 @@
node_modules/*
blueprint/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required so that the JSHinting of Ember CLI itself passes (otherwise it complains about <%= namespace %> inside of blueprint/app/router.js).

Please note that the tests for a newly generated project are still tested to ensure they pass JSHint. This happens in the smoke-test (which actually generates and calls ember test on a new project).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

rwjblue added a commit that referenced this pull request Jun 6, 2014
@rwjblue rwjblue merged commit cfb0009 into ember-cli:master Jun 6, 2014
@rwjblue rwjblue deleted the do-not-clobber-env branch June 6, 2014 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants