Split up vendor and appliation code. #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify, this fixes #947 by only processing ES3SafeFilter on the application code after it has been transpiled, and the need to split the vendor and app code came from moving the ES3SafeFilter to the end. If we attempt to process the entire concatted |
|
Can I hack this in to 0.0.32 in order to fix my comment on 947? |
|
@brandonparsons - No, I don't think that is a good idea (to modify in your |
|
Needs rebase. I'm going to try and release before work |
Generate an `/assets/vendor.js` in addition to `/assets/my-package.js`. Also, ensures that ES3SafeFilter is only ran on application code AFTER transpiling.
rwjblue
added a commit
that referenced
this pull request
Jun 9, 2014
Split up vendor and appliation code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate an
/assets/vendor.jsin addition to/assets/my-package.js.Also, ensures that ES3SafeFilter is only ran on application code AFTER transpiling.
Fixes #947.