Make sure the build traps SIGINT and SIGTERM for cleanup.
#971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
added a commit
that referenced
this pull request
Jun 10, 2014
Make sure the build traps `SIGINT` and `SIGTERM` for cleanup.
Merged
|
@stefanpenner I spent some time writing out a unit test for this and (as always) ended up digging into more files than I would have liked. Tests and changes are in this commit. Thought you may want to give it a look. @rjackson's solution (#973) covers more or less the same thing with less changes and probably more accuracy at the cost of taking slightly longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exiting from
ember serverstopped cleaning up the./tmpdirectory after exit, which means the directory would expand in size until manually deleted._MIGHT_ have caused some EMFILE errors as well. I have no proof. Though.
Traces back to a mis-refactor from https://github.com/stefanpenner/ember-cli/blob/v0.0.28/lib/utilities/build-builder.js#L16