Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor derive_type #267

Closed
leighmcculloch opened this issue Jul 21, 2022 · 1 comment
Closed

Refactor derive_type #267

leighmcculloch opened this issue Jul 21, 2022 · 1 comment

Comments

@leighmcculloch
Copy link
Member

Similar to #266 but for derive_type that is used for contracttype macro.

@leighmcculloch
Copy link
Member Author

Similar to #266 (comment) I think we should move the parsing logic into a type that implements syn::Parse.

I think it would be beneficial to then split the rendering logic into separate derive macros, where each derive macro reuses the same parsing logic. It would be ideal if we can only run the parsing logic once though, especially so we don't generate duplicate errors, so it might be that having them be entirely independent derive macros would be challenging, but otherwise they could be.

I'd think we should do this after and not before #153, and all the other tasks we have planned for macros currently.

@leighmcculloch leighmcculloch closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant