Change API field naming style to Camel Case. #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overcat
commented
May 9, 2024
| @@ -131,8 +131,8 @@ func (l *LedgerEntryChange) FromXDRDiff(diff preflight.XDRDiff) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // LedgerEntryChange designates a change in a ledger entry. Before and After cannot be be omitted at the same time. | |||
| // If Before is omitted, it constitutes a creation, if After is omitted, it constitutes a delation. | |||
| // LedgerEntryChange designates a change in a ledger entry. Before and After cannot be omitted at the same time. | |||
There was a problem hiding this comment.
Correct the typo here by the way.
|
Sadly, this is now a breaking change because we already released getVersionInfo endpoint https://github.com/stellar/soroban-rpc/releases/tag/v21.1.0 -- so now this change should go in next protocol bump just fyi |
|
@Shaptic are there downstream tickets to fix this? |
|
@janewang When would it be a good time to release this? (considering it's a breaking change) |
|
Not yet, since the answer is dependent on the release cycle (unfortunately I think we'd have to wait until Protocol 22 as it means breaking releases for all of the SDKs). |
Shaptic
approved these changes
Jul 17, 2024
Shaptic
approved these changes
Jul 17, 2024
|
+1, Protocol 22 is the time |
This was referenced Jul 19, 2024
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change API field naming style to Camel Case.
Why
Other APIs all use Camel Case style, let's keep it consistent.
Known limitations
[TODO or N/A]