Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate a Stellar asset into smart contracts using code #613

Closed
briwylde08 opened this issue May 29, 2024 · 7 comments · Fixed by #754
Closed

Integrate a Stellar asset into smart contracts using code #613

briwylde08 opened this issue May 29, 2024 · 7 comments · Fixed by #754
Assignees
Labels
Docs Bounty An issue eligible for you to complete for the Docs Bounty!

Comments

@briwylde08
Copy link
Contributor

briwylde08 commented May 29, 2024

Get awarded: up to $500 worth of XLM
Section: How-To Guides - Conventions: https://github.com/stellar/stellar-docs/tree/main/docs/smart-contracts/guides/conventions

Guide could include:

  • A detailed tutorial on how to code the integration of Stellar assets into Soroban smart contracts
  • Include code examples that show how to handle Stellar asset transactions, balance queries, and other related operations within a smart contract
@briwylde08 briwylde08 added the Docs Bounty An issue eligible for you to complete for the Docs Bounty! label May 29, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Dev Docs May 29, 2024
@tupui
Copy link
Contributor

tupui commented Jun 3, 2024

Provided you liked what I did with events, I could write something here.

I have played with Stellar assets and Soroban here https://github.com/tupui/soroban-seal-coin/blob/94a61ad64d39b1b01119458e4ac66e1a51410c4a/contract/src/lib.rs#L131-L138 (and see the tests) so I think I know what you mean here. (In terms of timeline, I can start working on that next week. This also leave time to maybe wrap up the other PR 😄)

Note to self: probably link to this new page #570

@briwylde08
Copy link
Contributor Author

Oh yeah that would be great. I'll give it to ya. And the program is running for 10 weeks, feel free to snag as many issues as you'd like!!

@briwylde08 briwylde08 moved this from Backlog to In Progress in Dev Docs Jun 3, 2024
@tupui
Copy link
Contributor

tupui commented Jun 17, 2024

I am trying to start on this one and realise that there is already sort of a guide in the doc, at least the first part, with https://developers.stellar.org/docs/smart-contracts/tokens/stellar-asset-contract

(I almost forgot that I actually worked a bit on that page 😅 stellar-deprecated/soroban-docs#718)

The second point is still a bit missing. So maybe an approach would be to carve out the last section (Using Stellar Asset Contract with other contracts) into a guide and add the missing bits there.

I also see #601 and maybe this could fit in this guide instead as I am not sure there is much more to say on just the minting + testing bit.

What do you think?

@briwylde08
Copy link
Contributor Author

briwylde08 commented Jun 18, 2024

Hi @tupui! Hmm. I actually think pulling out the Using the Stellar Asset Contract with other contracts and adding the missing pieces and turning that into a separate guide makes sense. I support that!

@briwylde08
Copy link
Contributor Author

Hi @tupui! Thank you so much for your contribution (combined with #601)!! The award amount for these two issues is $750 worth of XLM. Since you've already filled out the form with your previous submission, we can just use that information. Has anything changed since your last submission?

@tupui
Copy link
Contributor

tupui commented Jul 24, 2024

Thank you @briwylde08 🙏 yes we can use the same information, nothing changed 😃

@briwylde08
Copy link
Contributor Author

Great! We've logged your award of $750 worth of XLM which you should see in the next week! Thanks again for your amazing contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Bounty An issue eligible for you to complete for the Docs Bounty!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants
@tupui @briwylde08 and others