Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on VPC without a AWS::EC2::FlowLog attached to it #63

Closed
ghost opened this issue Oct 18, 2017 · 2 comments
Closed

Warn on VPC without a AWS::EC2::FlowLog attached to it #63

ghost opened this issue Oct 18, 2017 · 2 comments
Assignees
@archetypalsxe
Labels
customer Initiated from, or received feedback about from outside Stelligent feature good first issue

Comments

@ghost
Copy link

ghost commented Oct 18, 2017

Could be defined in another template so just warn
@ghost ghost closed this as completed May 8, 2019
@ghost ghost added the customer Initiated from, or received feedback about from outside Stelligent label May 30, 2019
@ghost ghost reopened this May 30, 2019
@twellspring
Copy link
Contributor

Warn if resources_by_type(AWS::EC2::VPC) exists and no resources_by_type(AWS::EC2::FlowLog) exist

Checking more specifically that the VPC is specified in the FlowLog ResourceID is possible but would mean this rule would warn if someone decided to use flow logs on subnets rather than the full vpc.

@archetypalsxe
Copy link
Contributor

Not able to assign myself, but I am working on this feature

archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Dec 4, 2019
@archetypalsxe
[stelligent#63] Adding yml templates for testing accordingly
5248d17
@archetypalsxe archetypalsxe self-assigned this Dec 5, 2019
archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Jan 31, 2020
@archetypalsxe
[stelligent#63] Adding yml templates for testing accordingly
bb3371a
archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Feb 23, 2020
@archetypalsxe
[stelligent#63] Adding yml templates for testing accordingly
319b677
archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Feb 23, 2020
@archetypalsxe
[stelligent#63] Adding custom rules and tests for warning on VPCs tha…
4f82ea3 
…t are missing

FlowLogs in the same template
archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Feb 23, 2020
@archetypalsxe
[stelligent#63] Adding custom rules and tests for warning on VPCs tha…
257afc1 
…t are missing

FlowLogs in the same template
archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Feb 26, 2020
@archetypalsxe
[stelligent#63] Adding custom rules and tests for warning on VPCs tha…
dbf351b 
…t are missing

FlowLogs in the same template
archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Feb 26, 2020
@archetypalsxe
[stelligent#63] Making sure that flowlogs are attached to VPCs rather…
b4487c8 
… than just

being in the same template
archetypalsxe added a commit to archetypalsxe/cfn_nag that referenced this issue Mar 1, 2020
@archetypalsxe
[stelligent#63] Adding additional tests for testing with multiple VPC…
fa02086 
…s and flow

logs
ghost pushed a commit that referenced this issue Mar 2, 2020
@archetypalsxe
#63 Adding a Warning for VPCs Missing FlowLogs (#382)
d5e0465 
* [#63] Adding custom rules and tests for warning on VPCs that are missing
FlowLogs in the same template

* [#63] Making sure that flowlogs are attached to VPCs rather than just
being in the same template

* [#63] Adding additional tests for testing with multiple VPCs and flow
logs
ghost pushed a commit that referenced this issue Mar 2, 2020
#63 fix rubocop
1684c94
ghost pushed a commit that referenced this issue Mar 2, 2020
#63 fix id collision
033ae3b
@ghost ghost closed this as completed Mar 4, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archetypalsxe archetypalsxe

Labels
customer Initiated from, or received feedback about from outside Stelligent feature good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twellspring @archetypalsxe