Refactoring for Metrics/LineLength Iteration #1 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterations: 1. 100 max 2. 90 max 3. 80 max (final iteration)
…names that only exist to game rubocop
…ike the way some code reads that is a hair long than 100. also use more natural and consistent select calls for a few of the rules
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Apr 18, 2019
* Refactoring for Metrics/LineLength Iteration #1 Iterations: 1. 100 max 2. 90 max 3. 80 max (final iteration) * #170 i bumped the metric up a bit... we all have wide screens and i like the way some code reads that is a hair long than 100. also use more natural and consistent select calls for a few of the rules * Refactoring for the following lint class cops * Lint/UnusedMethodArgument * Lint/RescueException * Lint/UnusedBlockArgument * Lint/StringConversionInInterpolation * Rebasing from master * #170 use select to clean up auth rule. Add ScriptError to protect from broken custom rules
ghost
pushed a commit
that referenced
this pull request
Apr 18, 2019
* Fixing various rubocop violations Made exceptions for some * Adding dockerfile for future DockerHub publishing (#168) * Refactoring for the following lint class cops (#173) * Refactoring for Metrics/LineLength Iteration #1 Iterations: 1. 100 max 2. 90 max 3. 80 max (final iteration) * #170 i bumped the metric up a bit... we all have wide screens and i like the way some code reads that is a hair long than 100. also use more natural and consistent select calls for a few of the rules * Refactoring for the following lint class cops * Lint/UnusedMethodArgument * Lint/RescueException * Lint/UnusedBlockArgument * Lint/StringConversionInInterpolation * Rebasing from master * #170 use select to clean up auth rule. Add ScriptError to protect from broken custom rules
ghost
pushed a commit
that referenced
this pull request
Apr 18, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterations: