Prevent duplicate ids #221
Conversation
| existing_def | ||
| @duplicate_ids << { | ||
| id: id, | ||
| new_message: message, |
There was a problem hiding this comment.
the new v. old is fine, but poking at two things:
- is the order stable for this to have meaning?
- on the off chance we have > 2 collisions... i guess it shows A/B and then B/C?
Perhaps make @duplicate_ids a Hash with id key and array of messages?
I guess there's no way to say where the duplicate class is coming from? for core rules this is a bug that we rightfully stop the release pipeline for..... but when there are custom rule directories that users are pointing to....
There was a problem hiding this comment.
I have suggested that custom rules have their own number system with a prefix of C. But yeah, this is just a barebones approach to fail CI builds when there are duplicates. The messages aren't perfect but they enabled me to quickly troubleshoot the one duplicate we had. If we want something fancier, we can always iterate on it in the future as need arises.
ghost
merged commit 
Closes #220