Iam AdministratorAccess managed policy rule #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Oct 15, 2019
| end | ||
|
|
||
| def rule_id | ||
| 'W25' |
There was a problem hiding this comment.
W25 used to be something i forgot... probably something with security groups that got collapsed. can you bump this to something higher? W38 maybe?
ghost
reviewed
Oct 15, 2019
|
|
||
| def audit_impl(cfn_model) | ||
| violating_roles = cfn_model.resources_by_type('AWS::IAM::Role').select do |role| | ||
| violating_policies = role.managedPolicyArns.select do |policy| |
There was a problem hiding this comment.
this is fine, but you could just do a "find" instead - quit after the first one since it only takes one to violate
ghost
reviewed
Oct 15, 2019
| "Action": ["sts:AssumeRole"] | ||
| } ] | ||
| }, | ||
| "ManagedPolicyArns" : [ "arn:aws:iam::aws:policy/AdministratorAccess" ] |
There was a problem hiding this comment.
this is likely good enough given how much other testing there is against IAM roles, but generally i would suggest also including a "positive" test whereby your prove the rule/violation won't be triggered.
ghost
approved these changes
Oct 15, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Look for AdministratorAccess managed policy in IAM Role #75
#75