Feature/add secure rule for alexa ask skill authentication configuration #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Dec 10, 2019
| def audit_impl(cfn_model) | ||
| ask_skills = cfn_model.resources_by_type('Alexa::ASK::Skill') | ||
| violating_skills = ask_skills.select do |skill| | ||
| refresh_token = skill.authenticationConfiguration['RefreshToken'] |
There was a problem hiding this comment.
one thing to be wary of - authenticationConfiguration is required but you could face a malformed template. haven't been totally consistent about handling this. cfn-model can hide/catch some of these issues up front so rule developers don't have to think about it..... you could add a kwalify schema into cfn-model, or you could check missing authenticationConfiguration here.
There was a problem hiding this comment.
if somebody jams an Fn::If at the top-level of properties, cfn-model is going to ignore the FnIf, but then the resource will have no properties. there are a lot of places that are going to possibly break with that.... so not something you nec need to care about.
ghost
suggested changes
Dec 10, 2019
ghost
approved these changes
Jan 6, 2020
ghost
deleted the
feature/add_secure_rule_for_alexa_ask_skill_authentication_configuration
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322
Creating two new rules for
Alexa::ASK::Skill.AuthenticationConfigurationThese rules are using the
BaseRuleclass. New specs are created to test familiar template scenarios.