Adding warning rule for cognito IdentityPool AllowUnauthenticatedIdentities - #68 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcelhattan
changed the title
tmcelhattan
changed the title
…f a property is referencing a parameter and another method for getting that parameter's Default value.
ghost
reviewed
Feb 17, 2020
| end | ||
|
|
||
| def violating_identity_pool?(identity_pool) | ||
| ip_prop = identity_pool.allowUnauthenticatedIdentities |
There was a problem hiding this comment.
same issue with parameter subsitution values as for the user pool PR
ghost
suggested changes
Feb 17, 2020
added 2 commits
February 17, 2020 16:04
ghost
approved these changes
Feb 17, 2020
ghost
deleted the
feature/68_cognito_identity_pool_allow_unauntheticatedidentities
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#68
Add rule to warn if AWS::Cognito::IdentityPool has AllowUnauthenticatedIdentities property set to 'true'. This property should be false but CAN be true only if the proper IAM role and permissions are established for unauthenticated users.