#141 Upgrading cfn-model version to inherit Globals section parsing #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-update Updating deprecated 'version' property to 'ruby-version' for setup-ruby action.
… parsing and adding validation test.
ghost
approved these changes
Feb 21, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
Description
This PR upgrades the stelligent/cfn-model dependency to the latest version to inherit the Globals section parsing for use in custom rules. It also adds a validation test to ensure globals are accessible from the parsed template.
Testing
Ran all rspec tests successfully including new validation and regression tests.