Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokio integration #6

Open
little-dude opened this issue Jan 22, 2018 · 6 comments
Open

Tokio integration #6

little-dude opened this issue Jan 22, 2018 · 6 comments

Comments

@little-dude
Copy link

little-dude commented Jan 22, 2018

Hi,

I'm trying to write an expect crate. The problem is, I want non-blocking IO on the master pty, so that I can implement timeouts. For now, I copy-pasted the TtyServer implementation and made the tokio integration: https://github.com/little-dude/expect-rs/blob/master/src/pty.rs.

Do you think this kind of stuff would be worth adding to tty-rs as a separte type, like AsyncTtyServer ?

Thanks for this crate, I learnt a lot just about ttys just by reading your code :)

@mikroskeem
Copy link

Bump, any updates on this? @little-dude's code is gone as well somewhere

@mikroskeem
Copy link

Oh thank you, forgive my laziness 😄

@little-dude
Copy link
Author

I'm glad if it's helpful :)

@l0kod
Copy link
Member

l0kod commented May 27, 2018

I missed this issue. :/

Do you think this kind of stuff would be worth adding to tty-rs as a separte type, like AsyncTtyServer ?

Yes, that would be great! :)

You may need to add a feature gate for the Tokio dependency, though.

However, tty-rs is not MIT. ;)

@little-dude
Copy link
Author

However, tty-rs is not MIT. ;)

Oh, I hadn't noticed. If I use it as a dependency, I need to license my crate under GPL instead of MIT then, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants