Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting an event's occurrences causing the event to disappear #367

Closed
stephenharris opened this issue Jun 29, 2016 · 0 comments
Closed

Comments

@stephenharris
Copy link
Owner

Originally reported here: http://wp-event-organiser.com/forums/topic/identical-entries-appearing-twice-in-list-deleted-but-both-still-there/#post-23262

Deleting all the occurrences of an event (i.e. via the admin calendar) causes the event to disappear from the event admin list and calendar, and causes its page to 404. However, it still appears in the event list shortcode (with no date).

This appears to have been introduced in 3.1.0. The fix should allow such events to be visible in the admin screen, and deleting an event's last remaining occurrence should probably delete the entire event.

@stephenharris stephenharris added this to the 3.2.0 milestone Jun 29, 2016
stephenharris pushed a commit that referenced this issue Jun 29, 2016
…last remaining occurrence has been deleted, delete the entire event. Change success message occordingly and change delete link text accordingly. Ref #367.
@stephenharris stephenharris modified the milestones: 3.1.1, 3.2.0 Jul 8, 2016
stephenharris added a commit that referenced this issue Jul 8, 2016
…ronologically earliest matching date.

This is fixed by using an INNER join rather than LEFT join. This however effectivley reverted the fix for
inner join with a result set that did not include that events ID.

The fix is to check for any date-based where conditinos. If none are present that it is resonable to return
events that do not have any dates. Typically this might only be expected on the Events admin page.

Ref #367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant