Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circles Are Ovally When the Display Font Is Changed #61

Closed
MarvNC opened this issue Jan 20, 2024 · 5 comments · Fixed by themoeway/yomitan#556
Closed

Circles Are Ovally When the Display Font Is Changed #61

MarvNC opened this issue Jan 20, 2024 · 5 comments · Fixed by themoeway/yomitan#556
Assignees
Labels
bug Something isn't working

Comments

@MarvNC
Copy link

MarvNC commented Jan 20, 2024

Original chart:
chrome_Yomitan_Search_-発条-_Yomitan_Search_2024-01-19_22-27-54
After applying css:

* {
  font-family: 'Noto Sans JP', sans-serif;
}

chrome_Yomitan_Search_-発条-_Yomitan_Search_2024-01-19_22-27-33

Of course this is a really minor issue and I have no idea how it could be fixed, just wanted to bring this to your attention if you weren't already aware. Feel free to close if not feasible.

@stephenmk
Copy link
Owner

just wanted to bring this to your attention if you weren't already aware.

Thanks. Yes, I've already spent some time pulling my hair out over it. I guess since it's the font, I'd need to find some way to draw the circle that doesn't involve the text.

I'll leave this issue open since this really is something I need to fix.

@stephenmk stephenmk self-assigned this Jan 20, 2024
@stephenmk stephenmk added the bug Something isn't working label Jan 20, 2024
@stephenmk
Copy link
Owner

https://developer.mozilla.org/en-US/docs/Web/CSS/clip-path

I can replace most of the padding and border-radius style stuff I'm doing with a simple clip-path: circle() style to get the effect that I want. I'll have to submit another tiny patch to yomitan to add support for it.

circle

@koiyakiya
Copy link

Is this still being worked on? I know it's a minor thing, but it sometimes really bugs me lol

@MarvNC
Copy link
Author

MarvNC commented Feb 15, 2024

Waiting on the SC changes to be released to Yomitan stable, likely.

@stephenmk
Copy link
Owner

The patch that I submitted to Yomitan in January (described and linked above) was released in a new stable version on April 14.

Starting with version 4.7, new releases of Jitendex for Yomitan should not have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants