Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when CHOOSE LANGUAGE is selected #116

Open
tdtsh opened this issue Mar 26, 2017 · 3 comments · May be fixed by #120
Open

Crash when CHOOSE LANGUAGE is selected #116

tdtsh opened this issue Mar 26, 2017 · 3 comments · May be fixed by #120

Comments

@tdtsh
Copy link
Contributor

tdtsh commented Mar 26, 2017

Problem

If you select CHOOSE LANGUAGE with promise-it-wont-hurt, it exits immediately after the language selection menu is displayed

Execution environment

  • MacOS 10.12.3
  • Node.js 6.10.0
  • Commit: 2e22b12

Reproduction procedure

git clone git@github.com:stevekane/promise-it-wont-hurt.git
npm i
node promise-it-wont-hurt
Move the cursor to CHOOSE LANGUAGE and press the Enter key

Expected result

We can select a language from the language selection menu.

Possible cause

@timothygu/workshopper menu.js

I think the following lines are unnecessary.

  })

  menu.on('close', function () {
@tdtsh
Copy link
Contributor Author

tdtsh commented Mar 26, 2017

Published npm package of @timothygu/workshopper@^2.7.4 is not contain following pullrequest I think.

https://github.com/workshopper/workshopper/pull/128/files

@watilde
Copy link

watilde commented Mar 27, 2017

it worked with these updates: watilde@0859100, watilde@e65e7fe. It seems to be worth to try, but I guess there is something reason why this workshop is using @TimothyGu 's forked module.

@tdtsh
Copy link
Contributor Author

tdtsh commented Mar 27, 2017

Thanks a lot! @watilde but, this fix seems to cause another bug.

  • how to reproduction

Move the cursor to CHOOSE LANGUAGE and press the Enter key
Choose language (ex. English)
Choose lesson (ex. Warm up)

events.js:91
      listeners[i].call(self);
                  ^

TypeError: Cannot read property 'call' of undefined

tdtsh added a commit to tdtsh/terminal-menu that referenced this issue Apr 8, 2017
Crash when CHOOSE LANGUAGE is selected
stevekane/promise-it-wont-hurt#116
tdtsh added a commit to tdtsh/workshopper that referenced this issue Apr 8, 2017
Crash when CHOOSE LANGUAGE is selected
stevekane/promise-it-wont-hurt#116
tdtsh added a commit to tdtsh/promise-it-wont-hurt that referenced this issue Apr 8, 2017
tdtsh added a commit to tdtsh/workshopper that referenced this issue Apr 8, 2017
Crash when CHOOSE LANGUAGE is selected
stevekane/promise-it-wont-hurt#116
tdtsh added a commit to tdtsh/promise-it-wont-hurt that referenced this issue Apr 8, 2017
tdtsh added a commit to tdtsh/terminal-menu that referenced this issue Apr 8, 2017
Crash when CHOOSE LANGUAGE is selected
stevekane/promise-it-wont-hurt#116
@tdtsh tdtsh linked a pull request Apr 8, 2017 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants