Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio input not work with Visual Code 1.35.1 #63

Closed
leidd opened this issue Jun 28, 2019 · 18 comments
Closed

Audio input not work with Visual Code 1.35.1 #63

leidd opened this issue Jun 28, 2019 · 18 comments
Labels
bug external issue The issue presumably has to be fixed in a dependency wontfix

Comments

@leidd
Copy link

leidd commented Jun 28, 2019

I had update my Visual Code to 1.35.1, and update the Shader Toy plugin to 0.8.8,
and then I open the audio input setting, put the mp3 to the right place(if path is not correct, it will notice what went wrong),but when i preview with the shader, the audio input channel still not work, and has none error or notice. From the issue i know it added from 0.8.4, so if i want to experience, What shall I do?

@stevensona
Copy link
Owner

stevensona commented Jun 28, 2019

Audio input is disabled by default because it is still "experimental". Have you checked the "Enable Audio Input" setting?

@Malacath-92
Copy link
Collaborator

Audio input works for me.

If you have audio input disabled it should emit a warning when you use audio input. But it's worth checking that you do have it enabled for sure.
If it is enabled and not working, can you try executing the "Developer: Open Webview Developer Tools" (on Windows pressing Ctrl-Shift-P, start typing the command and select it when it appears). see if there is any pertinent information logged.
What file-type are you using? It could be that is is either not supported by the Web Audio implementation in Chromium or it's not recognized as an audio file by the mime library your using.

@Malacath-92
Copy link
Collaborator

@leidd can you check what we mentioned in our two replies above? Otherwise we will have to close the issue since we have no information to go on.

@Malacath-92 Malacath-92 added the bug label Jul 7, 2019
@leidd
Copy link
Author

leidd commented Jul 10, 2019

The audio input setting had enabled,
image
image
And then I Open Webview Developer Tools, it show errors
image

@Malacath-92
Copy link
Collaborator

@leidd this is weird. As long as you're using a local file I don't see why this would happen. Is it possible for you to upload the file so I can do some more debugging.

@leidd
Copy link
Author

leidd commented Jul 10, 2019

I used the mp3 in this project, it shows the same error, My operating system is MacOS, is there a problem? And the project struct like this
image

@Malacath-92
Copy link
Collaborator

It could be a Mac OS specific bug, but I have no way of testing that right now. I'll try to recreate your setup to see if there might be a more general issue.

@leidd
Copy link
Author

leidd commented Jul 10, 2019

Thanks, I will continue to focus on this

@Malacath-92
Copy link
Collaborator

I now have the same issues on my windows machine. Maybe last time I tried I didn't have an updated VSCode version. I'm kinda stumped how to prevent this problem though.

@leidd
Copy link
Author

leidd commented Jul 18, 2019

OK,I can just wait for your update, that's what i can do now ^_^

@Malacath-92
Copy link
Collaborator

This issue definitely was introduced in the June update of VSCode, I will try to mention the issue on their repo.

@Malacath-92
Copy link
Collaborator

Refer to this issue
It looks like it is a bug with the current bundled chrome version. I tested the exploration build, which bundles electron 6, where I do not experience the issue anymore. I'm sorry about this, but from what I can see there is nothing we can do on our side to work around this.

@Malacath-92 Malacath-92 added the external issue The issue presumably has to be fixed in a dependency label Aug 3, 2019
@markus-wa
Copy link

I'm still having this issue on the latest VS Code version. It seems it wasn't fixed by microsoft/vscode#78333.

Can anyone confirm that it works for them on VS Code 1.41.1?

@Malacath-92
Copy link
Collaborator

This is on my todo list after our next release. But right now it looks to me like the information I was given was incorrect/incomplete and the insiders build ships with a different version of Electron than the Insiders build that I was instructed to use, namely ffmpeg was stripped from the main release. Also on the most recent Insiders build the audio input does not work, so I assume they unified that across version. Not sure if we can do anything about this, other than go back to the older version.
I also plan to add a feature that lets users export their shaders to a portable html file, and those could support audio, given the browser used to display them supports the web audio api.
I'll post here if I learn more.

@markus-wa
Copy link

Unfortunate to hear. But thanks for the update 🙂

@ChrisProlls
Copy link

Any news about this ? The issue in the VS Code repo seems closed and I can't ask for news ...

@Malacath-92
Copy link
Collaborator

@ChrisProlls See my post from last week, I am under the impression now that VSCode will not support this anytime soon, if ever. I will investigate after our next release.

@Malacath-92
Copy link
Collaborator

Closing this, since it is not within the scope of this extension. An export to a portable html file is now available, though most likely it's necessary to host a server locally in order to open the file in modern browsers (since they shouldn't allow reading local files that easily)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug external issue The issue presumably has to be fixed in a dependency wontfix
Projects
None yet
Development

No branches or pull requests

5 participants