Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Windows' volume sometimes causes error for Realtek High Definition Audio #5

Closed
ICTman1076 opened this issue Jun 26, 2020 · 4 comments

Comments

@ICTman1076
Copy link

If I change the volume of my laptop using the standard Windows controls, Snap.net displays this error:

image

It then disables playback on that audio device. It does not always occur, but has happened to me a few times, and the last 2 times it happened as I changed volume (I wasn't paying attention the first time). Audio was not playing.

The audio devices I have:
image

Running Version 0.20.0.0 on Windows 10 version 1909 on a Lenovo Yoga 510.

@stijnvdb88
Copy link
Owner

Hi! Thanks for reporting the issue - it's a very difficult one to track down! Has it been happening often for you? It took me a week to be able to reproduce it with a debugger attached - the crash is happening in snapclient:

Exception thrown at 0x00007FF92A8EA799 in snapclient.exe: Microsoft C++ exception: int at memory location 0x00000037603F6F44.
Exception thrown at 0x00007FF9236102E7 (AudioSes.dll) in snapclient.exe: 0xC0000005: Access violation reading location 0xFFFFFFFFFFFFFFFF.

I will try to fix it, but could use your help in trying to figure out how to reproduce the issue :) It did happen when changing the Windows volume like you said, but there must be some condition before that as well (99% of the time, changing Windows volume did not cause it to crash). In my case, audio was playing

@ICTman1076
Copy link
Author

I also find it difficult to reproduce if I try, it tends to just happen when I'm doing something else. It's not happened to me while playing audio, but I haven't really been using snapcast recently so maybe I'm just yet to experience it.

I will have a fiddle around and see if I can work it out.

@lucianm
Copy link

lucianm commented Dec 29, 2020

Confirming this error also with the current Snap.Net 0.22.0.1

@stijnvdb88
Copy link
Owner

H again! I finally realized what was causing this: anything that causes snapclient's WasapiPlayer to be re-initialized (eg. switching streams), and then changing Windows volume. Just sent a PR with the fix, the crash should be gone with the next release of snapcast (0.25.0). Thanks again for reporting the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants