Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@initial overriding other responsive variant values #737

Closed
hwhmeikle opened this issue Aug 25, 2021 · 5 comments · Fixed by #875
Closed

@initial overriding other responsive variant values #737

hwhmeikle opened this issue Aug 25, 2021 · 5 comments · Fixed by #875
Labels
bug Something isn't working P1

Comments

@hwhmeikle
Copy link

hwhmeikle commented Aug 25, 2021

Bug report

Describe the bug

When using the responsive variant syntax I have observed that the @initial value sometimes overrides what is specified at @md .

To Reproduce

Code Sandbox: https://codesandbox.io/s/responsive-variants-t11m4?file=/src/App.tsx

  1. Ensure your screen width > 768px (to trigger the '@md' breakpoint)
  2. Click the 'Go to PageB' link
  3. Observe that on route /b the Icon's @md value is being overwritten by the @initial value
  4. Refresh the Code Sandbox rendering window
  5. Observe that the @md value is now overriding the @initial value.
  6. Click the 'Go to PageA' link
  7. Observe that the Icon's @md value is being overwritten by the @initial value

Expected behavior

I would expect that the @initial value is always overwritten by @md (when we are above > 768px).

Screenshots

@initial overwriting @md:

image

@md overwriting @initial after refresh:

image

@hwhmeikle hwhmeikle changed the title '@initial' overriding other responsive variant values @initial overriding other responsive variant values Aug 25, 2021
@peduarte peduarte added bug Something isn't working P1 labels Aug 26, 2021
@peduarte
Copy link
Contributor

@jonathantneal followed steps provided and verified as a bug.

@klaasman
Copy link

I just ran into this issue, any ETA or help needed investigating?

@hadihallak
Copy link
Member

this is now fixed in #875 and is pending release so i'm gonna keep the issue open until we release it publicly

@hadihallak
Copy link
Member

This is now fixed in a release candidate under the version 1.2.6-0 under a canary tag.
Should be pretty stable if you'd like to upgrade now but expect a final release sometime next week once we finish migrating our products to use the updated version.

Please, don't hesitate in providing us with any feedback regarding this release. very much appreciated 🙏

@hadihallak
Copy link
Member

Published under 1.2.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants