Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings for use of embedded_hal::digital::v1 traits #70

Closed
sapir opened this issue Jun 3, 2019 · 3 comments
Closed

Deprecation warnings for use of embedded_hal::digital::v1 traits #70

sapir opened this issue Jun 3, 2019 · 3 comments

Comments

@sapir
Copy link

sapir commented Jun 3, 2019

I'm getting deprecation warnings for using the GPIO pins, like:

warning: use of deprecated item 'embedded_hal::digital::v1::OutputPin::set_high': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
@TheZoq2
Copy link
Member

TheZoq2 commented Jun 6, 2019

This is certainly a problem, @therealprof you said "Not sure we really want to deal with the fall out and actually how to deal with it." in #63, but it feels like we have to do it at some point. Or are there more changes to the digital api planned?

@therealprof
Copy link
Member

No idea, I've not been a big fan of this whole digital::v2 mess to begin with but the jury is still out how to properly address the fallout.

CC rust-embedded/embedded-hal#139
CC rust-embedded/embedded-hal#135

@TeXitoi
Copy link
Contributor

TeXitoi commented Nov 16, 2019

That's fixes, no?

Feel free to reopen if that's not the case.

@TeXitoi TeXitoi closed this as completed Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants