Set i2c frequency using Hertz #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheZoq2
force-pushed
the
i2c_frequency_unit
branch
from
d150398 to
6e46559
Compare
TeXitoi
approved these changes
Nov 14, 2019
|
Any blocker on this or can it be merged? |
|
I think it can be merged, unless we want to allow |
|
True, |
|
I added methods to construct Mode from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #127 I realised that i2c doesn't use the Hertz structs to set freuency. This seems strange, so I fixed it.
Unlike the other peripherals, this doesn't allow construction from
KiloHertzorMegaHertzas that would have required making themodestruct generic, which would propagate a lot. It might still be a good idea to do so, though perhaps it's better to pass the frequency separately to the i2c "constructor". This would require less generics.