Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spi Deref #182

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Spi Deref #182

merged 2 commits into from
Feb 9, 2020

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Feb 2, 2020

Part of #161

Spi only and Deref.

rustfmt for spi.rs

Make RccBus sealed instead of Reset and Enable.

cc @TheZoq2

@burrbull burrbull mentioned this pull request Feb 2, 2020
Closed
@TheZoq2
Copy link
Member

TheZoq2 commented Feb 9, 2020

Sorry for the delay!

Looks good apart from the usual question: Would you mind adding a changelog entry? :)

@burrbull
Copy link
Member Author

burrbull commented Feb 9, 2020

Done.

therealprof
therealprof approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof therealprof merged commit 914ef01 into stm32-rs:master Feb 9, 2020
@burrbull burrbull mentioned this pull request Feb 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @TheZoq2 @therealprof