SCK, MISO, MOSI

[burrbull]

Use only this sequence.

Related to #339.
Need decision. What we need more? Possibility to pass pins in custom sequence or more simple API.
cc @TheZoq2 @therealprof @TeXitoi @adamgreig @thalesfragoso

[burrbull]

Also we could add advanced trait

pub trait SpiExt<SPI> {}

impl<SPI, REMAP, PINS> SpiExt<SPI> for Spi<SPI, REMAP, PINS, u8>
where
    REMAP: Remap<Periph = SPI>,
    PINS: Pins<REMAP>,
{
}

that would let write just

fn setup() -> (impl SpiExt<SPI1>, PA4<Output<PushPull>>) {

But this is rare needed case.

[TeXitoi]

I'm fine with removing the free order agrument.

[pdgilbert]

FWIW, the PR is working (using Spi<SPI1, Spi1NoRemap, impl Pins<Spi1NoRemap>, u8>,) in my testing too.

[burrbull]

bors r=TeXitoi

[bors]

🔒 Permission denied

Existing reviewers: click here to make burrbull a reviewer

[TeXitoi]

bors r+

[bors]

Configuration problem:
bors.toml: not found

[TeXitoi]

I think there is no bors here.

[burrbull]

I think there is no bors here.

Do you have permissions for manual merge?

[TeXitoi]

Yes, that's a long time I didn't to it here. rebase and merge?

[TeXitoi]

Looks more like squash and merge here.

[burrbull]

Yes, that's a long time I didn't to it here. rebase and merge?

Just merge.

Could we add bors?

[TeXitoi]

I have nothing against that. @TheZoq2 ?

[TheZoq2]

Looks like I'm late, but I have nothing against that. I'll have to learn how to use it, but that should be no problem :)

Re: merge/rebase/squash, I like to keep a linear history so I tend to squash PRs with small changes and many random commits, and rebase the rest.